Merged
Conversation
oxe-i
reviewed
Mar 6, 2026
|
|
||
| def plants (diagram : String) (student: String) : Vector Plant 4 := | ||
| let letters := diagram.toList | ||
| let first := 2 * ((student.toList)[0]!.val.toNat - 65) |
Contributor
There was a problem hiding this comment.
You can use student.front to access the first letter in a String. Since Lean is not lazy, .toList is O(n).
oxe-i
reviewed
Mar 6, 2026
| let second := first + 1 | ||
| let third := (diagram.length + 1) / 2 + first | ||
| let fourth := third + 1 | ||
| let firstPlant := lookup letters[first]! |
Contributor
There was a problem hiding this comment.
We can access individual Chars using String.Pos.get. In the version we are using, if we cast String to String.Slice and get startPos with, e.g., letters := diagram.toSlice.startPos, then we can use (letters.nextn first).get! to get the letter at position first.
I found that the Lean version we are using is right in the middle of an API change to the String type. In the latest version there is no need to cast String to String.Slice, this is done implicitly.
oxe-i
approved these changes
Mar 6, 2026
keiravillekode
force-pushed
the
kindergarten-garden
branch
from
a59d055 to
acc823e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.